Add serializers and deserializers for Jupyter's default websocket protocol#3
Add serializers and deserializers for Jupyter's default websocket protocol#3
Conversation
protocol * Adds a default serializer/deserializer - Logic unabashedly swiped from https://github.com/jupyterlab/jupyterlab/blob/main/packages/services/src/kernel/serialize.ts#L216 * Sets default values for the protocol as DEFAULT since it's... the default * Adds simple testing for the serializers/deserializers * Fixes minor bug with the logger being angry about multiple channels being defined
teeler
left a comment
teeler
left a comment
There was a problem hiding this comment.
Strong feelings about keeping V1 as the default (i suspect upstream will want to keep it that way)
Otherwise curious about your thoughts in keeping JSON/"COLAB" around as an explicit protocol
wh1ter4bb1t-js
left a comment
wh1ter4bb1t-js
left a comment
There was a problem hiding this comment.
Thanks for the review
|
i jumped infront with the uv.lock file so you'll need to fix that first :/ but then let's check this bad boy in |
|
@echarles fyi - we added proper support for the 'default' protocol here. My colleague has uncovered some interesting default behavior in Jupyter - that there is a 'json' fallback parser iff the opcode is text (which happens implicitly when there are no binary buffers being sent) |
|
@teeler Thas sounds like a good move. I may have a general question on how we can align our efforts. eg. I have opened datalayer#35 to backport your first change. I can also backport this one, but at some point we may diverge as I may have more questions on #2 How do you see the future of this fork? |
3 participants
default
being defined